Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dm: upgrade go-mysql library (#11043) #11187

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #11043

What problem does this PR solve?

Issue Number: close #11041

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

upgrade go-mysql to fix the connection blocked when read handshake packet

@ti-chi-bot ti-chi-bot added lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. labels May 28, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request May 28, 2024
1 task
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jul 26, 2024
@D3Hunter
Copy link
Contributor

/retest

Copy link
Contributor

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

ti-chi-bot bot commented Jul 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jul 30, 2024
@D3Hunter
Copy link
Contributor

/retest

Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-8.1@c3460e2). Learn more about missing BASE report.

Additional details and impacted files
Components Coverage Δ
cdc 61.7118% <0.0000%> (?)
dm 51.2465% <0.0000%> (?)
engine 63.4232% <0.0000%> (?)
Flag Coverage Δ
unit 57.4347% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             release-8.1     #11187   +/-   ##
================================================
  Coverage               ?   57.4347%           
================================================
  Files                  ?        852           
  Lines                  ?     125713           
  Branches               ?          0           
================================================
  Hits                   ?      72203           
  Misses                 ?      48098           
  Partials               ?       5412           

@D3Hunter
Copy link
Contributor

/retest

3 similar comments
@D3Hunter
Copy link
Contributor

/retest

@D3Hunter
Copy link
Contributor

/retest

@D3Hunter
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot bot merged commit a51c534 into pingcap:release-8.1 Jul 30, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants